Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding running bridges tests to phpunit.xml config #993

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Sep 14, 2023

Q A
Bugfix? ✔️
Breaks BC?
New feature?

What was changed

  1. The phpunit.xml configuration file was missing configuration for bridge tests. Fixed.
  2. The spiral/dotenv-bridge tests have been fixed; the bootloader no longer uses a callback.
  3. Added InvokerStrategyInterface and InitializerInterface binding.
  4. Abstract classes have been renamed from *Test to *TestCase.

Before these changes:

11

After these changes:

222

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.44% 🎉

Comparison is base (cc53ed1) 83.95% compared to head (a2334cf) 89.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #993      +/-   ##
============================================
+ Coverage     83.95%   89.39%   +5.44%     
  Complexity     6087     6087              
============================================
  Files           800      800              
  Lines         17141    17148       +7     
============================================
+ Hits          14390    15329     +939     
+ Misses         2751     1819     -932     
Files Changed Coverage Δ
src/Bridge/Monolog/tests/HandlersTest.php 97.82% <ø> (+97.82%) ⬆️
src/Bridge/Monolog/tests/LoggerTest.php 86.66% <ø> (+86.66%) ⬆️
src/Bridge/Monolog/tests/ProcessorsTest.php 97.61% <ø> (+97.61%) ⬆️
src/Bridge/Monolog/tests/RotateHandlerTest.php 87.50% <ø> (+87.50%) ⬆️
src/Bridge/Monolog/tests/TraitTest.php 92.59% <ø> (+92.59%) ⬆️
src/Bridge/Stempler/tests/BaseTestCase.php 94.28% <ø> (ø)
src/Bridge/Stempler/tests/CacheTest.php 100.00% <ø> (+100.00%) ⬆️
src/Bridge/Stempler/tests/ConfigTest.php 100.00% <ø> (+100.00%) ⬆️
src/Bridge/Stempler/tests/DirectiveTest.php 100.00% <ø> (+100.00%) ⬆️
src/Bridge/Stempler/tests/EngineTest.php 100.00% <ø> (+100.00%) ⬆️
... and 5 more

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 009c64c into spiral:master Sep 14, 2023
9 checks passed
@butschster butschster added this to the 3.9 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants