Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/scaffolder] Changing job payload type from array to mixed #992

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature?
Issues #943

What was changed

Changed the type of payload in the generated JobHandler from array to mixed.

use Spiral\Queue\JobHandler;

/**
 * Sample Job Handler
 */
final class SampleJob extends JobHandler
{
    public function invoke(string $id, mixed $payload, array $headers): void
    {
    }
}

@msmakouz msmakouz self-assigned this Sep 13, 2023
@msmakouz msmakouz linked an issue Sep 13, 2023 that may be closed by this pull request
@msmakouz msmakouz added this to the 3.9 milestone Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (cc53ed1) 83.95% compared to head (364d371) 83.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #992      +/-   ##
============================================
- Coverage     83.95%   83.94%   -0.01%     
  Complexity     6087     6087              
============================================
  Files           800      800              
  Lines         17141    17141              
============================================
- Hits          14390    14389       -1     
- Misses         2751     2752       +1     
Files Changed Coverage Δ
...affolder/src/Declaration/JobHandlerDeclaration.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit fe8484a into spiral:master Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[spiral/scaffolder] Change JobHandler payload type to mixed
2 participants