Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to configure the Attributes cache or disable the cache #968

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature? ✔️

What was changed

A new cache section with enabled and storage settings has been added to the attributes.php configuration file.

return [
    // ...
    'cache' => [
        'storage' => env('ATTRIBUTES_CACHE_STORAGE', 'file'),
        'enabled' => env('ATTRIBUTES_CACHE_ENABLED', true),
    ],
];

The cache is disabled by default because, since Framework v3.8.0, a connection error is displayed if the RoadRunner cache is used and RoadRunner is not running.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (32ce0e6) 83.73% compared to head (4d63720) 83.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #968      +/-   ##
============================================
+ Coverage     83.73%   83.74%   +0.01%     
- Complexity     6038     6040       +2     
============================================
  Files           793      793              
  Lines         17007    17015       +8     
============================================
+ Hits          14240    14249       +9     
+ Misses         2767     2766       -1     
Files Changed Coverage Δ
...ork/Bootloader/Attributes/AttributesBootloader.php 91.42% <100.00%> (+1.10%) ⬆️
...amework/Bootloader/Attributes/AttributesConfig.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 999948d into spiral:master Aug 15, 2023
9 checks passed
@butschster butschster added this to the 3.8 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants