[spiral/prototype] Initialize PrototypeRegistry only when registry requires from container #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
============================================
- Coverage 89.40% 89.14% -0.27%
- Complexity 6122 6124 +2
============================================
Files 811 812 +1
Lines 17314 17312 -2
============================================
- Hits 15480 15433 -47
- Misses 1834 1879 +45
☔ View full report in Codecov by Sentry. |
butschster
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request improves the way
Spiral\Prototype\PrototypeRegistryinitializes. Previously, it was initialized upon application bootstrap, even when not in use, leading to inefficient resource consumption. The change introducedSpiral\Prototype\Config\PrototypeConfig, which serves as a central configuration file for managing bindings. Third-party packages can now easily contribute their own bindings to this configuration via bootloader.The PrototypeRegistry is now created only when first requested from the container and utilizes the bindings defined in PrototypeConfig.