[spiral/reactor] Fix Psalm issues and tests in Reactor #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=========================================
Coverage 89.41% 89.41%
Complexity 6119 6119
=========================================
Files 810 810
Lines 17303 17303
=========================================
Hits 15471 15471
Misses 1832 1832
☔ View full report in Codecov by Sentry. |
msmakouz
changed the title
butschster
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omitEmptyNamespacesparameter was added with the default valuetrue:https://github.com/nette/php-generator/releases/tag/v4.1.1
Now if the namespace is empty or use is not used anywhere, the printer does not print it. The use of these elements has been added in tests.