-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a filter option to the Bills screen #1308
base: master
Are you sure you want to change the base?
Conversation
created a form in the html to filter the bills
implemented the filter feature for bills based on start date and end date.
Hi, thanks for the proposal. Is this something you need yourself? Could you share a screenshot of how this new feature looks like in the interface? As you may have seen, UI/UX considerations are important for the project (see https://github.com/spiral-project/ihatemoney?tab=readme-ov-file#current-direction-as-of-2024) |
Hi, this feature is submitted as an issue in #1155 by another user and I implemented it. I also think this is a very useful and fundamental feature since we can sort out the transaction based on a period of time and see how much is being spent within that time. Below is a screenshot of the filter feature in the interface (note that we can always improve the look later using css) |
Thanks for this work. I wonder if we should only display it when we have a certain number of bills (maybe when we have more than a page). What do you think? |
Personally I would like this option to be consistent to be on the screen no matter how many bills there are, since sometimes people do want to filter and sort out their bills even though there are not many of them. |
That seems okay to me. I was suggesting this because this can "clutter" the UI, by showing too many options, especially for new projects. Maybe we could hide this behind a "filter bills" link, or something similar? |
Yea that sounds good to me! |
+1 |
Closes #1155
Hi, I just implemented a new feature as requested in the issue #1155 that we can filter the bill screen based on start date and end date. I made changes in three files - added a filter form in the list_bills.html template, and added corresponding functions in the model.py and web.py. I hope it would be helpful!