-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English showcase #1273
base: master
Are you sure you want to change the base?
English showcase #1273
Conversation
… in the frontend structure
- Put the images in a language folder ("en", "fr"), which will make it easier to add orther languages later on. - Resize the images to fit the already existing ones. - Add a `display_showcase` parameter to the `list_bills` and `home` views.
Hey, thanks for your work @TheodoreCouz ! Here is a review on the current version (not sure what comes from you or from @almet ):
|
Thanks for the feedback.
The setting was actually intended, so that if your language is in there, then the button is displayed, and fallsback to english if your language isn't there. But we could also always display it.
Ah, I missed these ones. I'll add them to the translation.
:-) |
Some work to integrate what @TheodoreCouz has done in #1271