Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Provide a default prefix to compile in sqlStatement #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Provide a default prefix to compile in sqlStatement #63

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebdd16f
Provide a default prefix to `compile` called from `sqlStatement` in A…
sylbru Mar 10, 2021
77e96cd
Use single quotes for consistency
sylbru Mar 10, 2021
9f0a620
Cosmetic change in order to be able to rerun CI checks
sylbru Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Query/ActiveQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function sqlStatement(QueryParameters $parameters = null): string

return $this->driver->getQueryCompiler()->compile(
$parameters ?? new QueryParameters(),
$this->prefix,
$this->prefix ?? "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using single quotes instead of double quotes. It’ll be more consistent

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

$this
);
}
Expand Down