fix(artifactStore): Make applicationsRegex pattern matching case-insensitive #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front50 applications in many situations (especially when created via templates or pipeline as code automation) have a mix of Upper/Lower case names. Deck is always presenting the application names in lower-case so the end-user needs to query front50 directly to find out how the application name is actually stored.
This PR is making the pattern matching for the artifactStore enabling per application as case-insensitive to avoid a situation when the user expects the artifact-store to be enabled in an application and finds out it is stored in different case in front50.