refactor(retrofit/test): simplify the code by replacing RetrofitException.httpError with SpinnakerHttpException #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
| this.retrofit2Response = syncResp; | ||
| this.response = null; | ||
| this.retrofit = retrofit; | ||
| responseBody = this.getErrorBodyAs(); |
There was a problem hiding this comment.
This may belong in a followup PR, but...if we can't parse the response body as json to build a map, we'd eventually like the exception message to include some part of the response. I think that means we need a function like processResponse that sets responseBody and either rawMessage or the "plain" message field in this exceptional case.
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 18, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
00d7d58
to
63ffe23
Compare
dbyron-sf
reviewed
Jul 19, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
211f0c9
to
d189f3d
Compare
dbyron-sf
reviewed
Jul 20, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 20, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
d189f3d
to
95e8075
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
4 times, most recently
from
00fc79f
to
b4d1b59
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
5 times, most recently
from
3ae55e5
to
a2a0b9d
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
a2a0b9d
to
ba4c5e9
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
befd121
to
ba4c5e9
Compare
SheetalAtre
changed the title
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
8e9f599
to
ba4c5e9
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
a76d050
to
ba4c5e9
Compare
SheetalAtre
force-pushed
the
retrofitException_createHttpException
branch
from
bfc2b63
to
d5a91bf
Compare
…from a RetrofitError
…to allow to set custom properties in error response body
…o remove RetrofitException class later
… it will always be of type Map
…n to remove createSpinnakerHttpException() later
…etrofitException.httpError() later
…in all files to simplify code
dbyron-sf
force-pushed
the
retrofitException_createHttpException
branch
from
d5a91bf
to
1c45e6f
Compare
and pass it a Retrofit object so we no longer need a Retrofit member
… in SpinnakerHttpException since most members and methods are nullable
…ion.getRawMessage declaration
dbyron-sf
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(retrofit/test): simplify the code by replacing RetrofitException.httpError with SpinnakerHttpException
and removing RetrofitException