feat(retrofit) : give custom message for RetrofitException response body convert error #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jul 17, 2023
| @@ -67,16 +73,38 @@ public Response getResponse() { | |||
| * @throws RuntimeException wrapping the underlying IOException if unable to convert the body to | |||
| * the specified {@code type}. | |||
| */ | |||
| public <T> T getErrorBodyAs(Class<T> type) { | |||
| public Map getErrorBodyAs() { | |||
There was a problem hiding this comment.
Suggested change
| public Map getErrorBodyAs() { | |
| public Map<String, Object> getErrorBodyAs() { |
dbyron-sf
reviewed
Jul 17, 2023
| @@ -45,8 +49,10 @@ public static RetrofitException httpError(Response response, Retrofit retrofit) | |||
| */ | |||
| private final Retrofit retrofit; | |||
|
|
|||
| RetrofitException(String message, Response response, Retrofit retrofit) { | |||
| super(message); | |||
| private static Map<String, Object> jsonErrorResponseBody; | |||
There was a problem hiding this comment.
Suggested change
| private static Map<String, Object> jsonErrorResponseBody; | |
| private static Map<String, Object> jsonErrorResponseBody = Map.of("message", "failed to parse response"); |
SheetalAtre
force-pushed
the
retrofitException_responseBody_convertError
branch
2 times, most recently
from
9bf0def
to
a699bb5
Compare
dbyron-sf
reviewed
Jul 17, 2023
| } | ||
| } | ||
|
|
||
| static { |
There was a problem hiding this comment.
From here below can disappear now, yes?
…vert SpinnakerHttpException responsebody
SheetalAtre
force-pushed
the
retrofitException_responseBody_convertError
branch
from
a833b10
to
11c41b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(retrofit) : give custom message for RetrofitException response body convert error