fix(plugins): Enable RemotePluginInfoReleaseCache bean only when the …

…property matches the condition (#1041) (#1070)

Last week during Github's downtime, because the RemotePluginInfoReleaseCache runs in the background every 1 minutes, it forced the plugins to be reloaded(downloaded again from Github), action which failed because the Github keys were rotated due to their security leak

The refresh of the plugins is caused by the updateManager.refresh() call in the refresh method of the RemotePluginInfoReleaseCache.

As far as we can tell, the concept of remote plugins is something that is not used at all. So we can opt-in for this cache refresh bean by manually setting spinnaker.extensibility.remote-plugins.cache.enabled to true

Incident report page: https://www.githubstatus.com/incidents/x7njwb481j9b

(cherry picked from commit f7c9ef7)

Co-authored-by: ovidiupopa07 <[email protected]>

kork-plugins/src/main/java/com/netflix/spinnaker/config/PluginsAutoConfiguration.java

@@ -237,6 +237,10 @@ public static PluginInfoReleaseProvider pluginInfoReleaseProvider(
  /** Not a static bean - see {@link RemotePluginsConfiguration}. */
  @Bean
  @Beta
+ @ConditionalOnProperty(
+ value = "spinnaker.extensibility.remote-plugins.cache.enabled",
+ havingValue = "true",
+ matchIfMissing = true)
  public RemotePluginInfoReleaseCache remotePluginInfoReleaseCache(
  Collection<PluginInfoReleaseSource> pluginInfoReleaseSources,
  SpringStrictPluginLoaderStatusProvider springStrictPluginLoaderStatusProvider,