feat(kayenta): Add Flag to Disable Canary Config UI Editing #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
stevenlandrydd
changed the title
stevenlandrydd
changed the title
stevenlandrydd
changed the title
stevenlandrydd
changed the title
apoorvmahajan
approved these changes
May 16, 2024
jasonmcintosh
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "disableConfigEdit" flag into the "Canary" settings of deck which will make the config edit portions of the canary config ui read only for all configs if the flag is set to true. This feature is intended for cases where the canary configs are being managed via code and deployed/updated via api calls to prevent drift and issues arising from manually made canary changes.
Images below show the state of the edit panels with the flag enabled.