feat: support specifying components in a SpinApp #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
bacongobbler and
rajatjindal
as code owners
bacongobbler
approved these changes
Oct 21, 2024
|
Hmm... The linter could be out of date. Would you mind bumping it to v1.61.0? |
kate-goldenring
force-pushed
the
component-filtering
branch
from
1adb888
to
32f2858
Compare
|
@bacongobbler all CI has passed so feel free to merge whenever |
bacongobbler
force-pushed
the
component-filtering
branch
2 times, most recently
from
569f04e
to
7e3766c
Compare
Signed-off-by: Kate Goldenring <[email protected]> Signed-off-by: Matthew Fisher <[email protected]>
bacongobbler
force-pushed
the
component-filtering
branch
from
7e3766c
to
e1289c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #86