fix: remove native unwind info #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
Mossaka,
jsturtevant,
radu-matei and
devigned
as code owners
Mossaka
reviewed
Oct 29, 2024
kate-goldenring
force-pushed
the
silence-libunwind
branch
from
10a0714
to
daad13d
Compare
Mossaka
approved these changes
Oct 29, 2024
Mossaka
reviewed
Oct 29, 2024
- Musl builds of the shim throw a libunwind error during startup due to Wasmtime failing to detect which unwind implementation to use. For now, turn off generating native unwind info Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
force-pushed
the
silence-libunwind
branch
from
daad13d
to
bbd1b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl builds of the shim throw a libunwind error during startup due to Wasmtime failing to detect which unwind implementation to use. For now, turn off generating native unwind info. A fix was added to Wasmtime bytecodealliance/wasmtime#9479 and should be in the 27.0.0 release. At that point we can turn this back on if desired.
fixes #210