New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for MSSQL dialect #232

Merged

soininen merged 1 commit into master from fix_mssql_dialect

Oct 29, 2024

Contributor

soininen commented Oct 29, 2024 •

edited

Loading

No-one uses MSSQL at least to my knowledge
Getting this to work would have required adding pyodbc module as dependency
The DSN information wasn't used anywhere so getting the feature to work would have required implementation effort.

No associated issue.

Checklist before merging

Documentation (also in Toolbox repo) is up-to-date
Release notes in Toolbox repo have been updated
Unit tests have been added/updated accordingly
Code has been formatted by black & isort
Unit tests pass


          Remove already broken support for MSSQL dialect

a496fbd

soininen merged commit 38c57b2 into master

10 checks passed

soininen deleted the fix_mssql_dialect branch

October 29, 2024 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet