Fix command line arg parsing from string #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User may have accidentally entered multiple spaces between the arguments which gives empty arguments when the string is blindly split at whitespace.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #132 +/- ##
========================================
Coverage 62.49% 62.50%
========================================
Files 46 46
Lines 3917 3918 +1
Branches 763 764 +1
========================================
+ Hits 2448 2449 +1
Misses 1312 1312
Partials 157 157 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User may accidentally enter multiple spaces between the arguments which we incorrectly parsed as empty arguments. This PR fixes the issue.
No associated issue
Checklist before merging