Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when opening Plugin dialogs #3035

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix crash when opening Plugin dialogs #3035

merged 1 commit into from
Jan 17, 2025

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Jan 17, 2025

This PR removes one moveToThread() call.

Fixes #3034

Checklist before merging

  • Code has been formatted by black & isort
  • Unit tests pass

@ptsavol ptsavol self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (27820ec) to head (26de855).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/plugin_manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3035      +/-   ##
==========================================
+ Coverage   67.17%   67.18%   +0.01%     
==========================================
  Files         193      193              
  Lines       37233    37232       -1     
  Branches     4472     4472              
==========================================
+ Hits        25011    25015       +4     
+ Misses      10954    10945       -9     
- Partials     1268     1272       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit 2178a13 into master Jan 17, 2025
21 of 22 checks passed
@ptsavol ptsavol deleted the issue_3034 branch January 17, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Toolbox becomes unresponsive when clicking on the options under "Plugins"
1 participant