Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data store specific stuff from Database manager #2990

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Oct 28, 2024

Database manager shouldn't know about specific project items.

This is a companion PR to spine-tools/spine-items#230

Re #2930

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Database manager shoudln't really know about specific project items.
Also, the system was pretty complicated compared to a simple
signal.

Re #2930
@soininen soininen merged commit b301489 into master Oct 28, 2024
8 of 16 checks passed
@soininen soininen deleted the 2930_fix_ds_db_checks branch October 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant