Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for Batchx509SVID RPC #5402
Add integration test for Batchx509SVID RPC #5402
Changes from all commits
1d27256
ce239f3
eea71f9
ec99cee
5f63d2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step as-is verifies that the entries exist, as created in the prior step.
however, neither this suite nor this step test the BatchNewX509SVID API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I talked with @zmt the batch API is called internally when we add a single entry or create a batch operation as the test is already doing. The check for the existence of the entry fullfils the purpose of the task case if they were created in a batch operation and actually exist the operation is working as expected, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I believe you're detailing is Batch Entry Create, not Batch X509 SVID.
if the former, then the test needs to be re-named and the README updated
if the intention is to cover the latter, then comment still stands- this test as-is is not covering either explicit usage of that API or implicit usage by the running agent (which https://github.com/spiffe/spire/blob/main/test/integration/suites/fetch-x509-svids/05-fetch-x509-svids may already be doing)