Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Dockerfile in tests #210

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

faisal-memon
Copy link
Collaborator

@faisal-memon faisal-memon commented Nov 11, 2024

The integration tests have a dockerfile to build a spiffe-helper container. This was added before we had a proper container build. This diff removes the redundant dockerfile and uses the one in the root of the repo.

Partially addresses #191

@faisal-memon faisal-memon marked this pull request as draft November 11, 2024 07:02
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
@faisal-memon faisal-memon marked this pull request as ready for review November 11, 2024 07:45
@faisal-memon faisal-memon added this to the 0.9.0 milestone Nov 12, 2024
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@faisal-memon faisal-memon merged commit 2550ab0 into main Nov 18, 2024
13 checks passed
@faisal-memon faisal-memon deleted the remove-redundant-dockerfile branch November 18, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants