RH release version comparison #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vholer
changed the title
ybhvf
added a commit
to NMTCC/puppet-elws
that referenced
this pull request
Jul 21, 2014
This commit updates the puppetfile to preemptively merge spiette/puppet-selinux#13
ybhvf
added a commit
to NMTCC/puppet-elws
that referenced
this pull request
Jul 21, 2014
This commit updates the puppetfile to preemptively merge spiette/puppet-selinux#13
|
I just hit this issue with CentOS 7 as well. It'd be excellent to get this fixed in the mainline/forge so that consumers don't need to keep forking the project! |
|
yes please |
|
We used $::operatingsystemmajrelease but this solution is good as well! Please, merge it back to master! |
|
We also forked to use $::operatingsystemmajrelease for Centos 7. Please merge it back to master. Thanks. |
|
+1, it would be great to merge this in master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CentOS 7 can contain version information consisted of three components
and current simple check
$::operatingsystemrelease < '7'fails on Puppet error"Error: comparison of String with 7 failed at". Function versioncmp is better for version comparisons.