Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid failures when cleaning up spiderpool resources due to resourceVersion conflicts. #4130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Sep 27, 2024

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4088

Special notes for your reviewer:

@ty-dc ty-dc added release/bug cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (4a2596e) to head (000caa0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
- Coverage   81.32%   80.81%   -0.51%     
==========================================
  Files          51       51              
  Lines        4519     4519              
==========================================
- Hits         3675     3652      -23     
- Misses        673      700      +27     
+ Partials      171      167       -4     
Flag Coverage Δ
unittests 80.81% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ty-dc
Copy link
Collaborator Author

ty-dc commented Sep 27, 2024

Waiting for PR #4126

@ty-dc ty-dc force-pushed the fix/clean-with-resoureversion-change branch from e4b948e to 000caa0 Compare September 30, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/bug
Projects
None yet
1 participant