Hopefully fix #929

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+### Fixed
+- Fixed a bug where previously existing blocks could be lost when new blocks had validation errors, if `autosaveDrafts` was disabled
+
 ## 5.2.12 - 2024-10-21
 
 ### Added

src/Field.php

@@ -32,7 +32,6 @@
 use craft\db\Table;
 use craft\elements\db\ElementQueryInterface;
 use craft\elements\User;
-use craft\enums\AttributeStatus;
 use craft\enums\Color;
 use craft\enums\PropagationMethod;
 use craft\errors\InvalidFieldException;
@@ -644,6 +643,12 @@ protected function inputHtml(mixed $value, ?ElementInterface $element = null, bo
                 $view->setInitialDeltaValue($this->handle, null);
             }
 
+            // If not autosaving drafts and validation errors occurred, ensure previously existing blocks don't get lost
+            // TODO: autosaveDrafts is deprecated, remove this when it is removed from Craft
+            if (!Craft::$app->getConfig()->getGeneral()->autosaveDrafts && $element?->hasErrors()) {
+                $view->setInitialDeltaValue($this->handle, null);
+            }
+
             return $view->renderTemplate('neo/input', [
                 'handle' => $this->handle,
                 'blocks' => $blocks,
@@ -802,17 +807,6 @@ public function getIsTranslatable(?ElementInterface $element = null): bool
         return $this->propagationMethod !== PropagationMethod::All;
     }
 
-    /**
-     * @inheritdoc
-     */
-    public function getStatus(ElementInterface $element): ?array
-    {
-        return $element->isFieldOutdated($this->handle) ? [
-            AttributeStatus::Outdated,
-            Craft::t('app', 'This field was updated in the Current revision.'),
-        ] : null;
-    }
-
     /**
      * @inheritdoc
      */