Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): update chart nvidia-device-plugin to 0.17.0 #1066

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

spicerabot[bot]
Copy link
Contributor

@spicerabot spicerabot bot commented Oct 31, 2024

This PR contains the following updates:

Package Update Change
nvidia-device-plugin minor 0.16.2 -> 0.17.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

NVIDIA/k8s-device-plugin (nvidia-device-plugin)

v0.17.0

Compare Source

  • Promote v0.17.0-rc.1 to GA

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@spicerabot
Copy link
Contributor Author

spicerabot bot commented Oct 31, 2024

--- kubernetes/apps/kube-system/nvidia-device-plugin/app Kustomization: flux-system/nvidia-device-plugin HelmRelease: kube-system/nvidia-device-plugin

+++ kubernetes/apps/kube-system/nvidia-device-plugin/app Kustomization: flux-system/nvidia-device-plugin HelmRelease: kube-system/nvidia-device-plugin

@@ -13,13 +13,13 @@

     spec:
       chart: nvidia-device-plugin
       sourceRef:
         kind: HelmRepository
         name: nvidia-device-plugin-charts
         namespace: flux-system
-      version: 0.16.2
+      version: 0.17.0
   install:
     crds: CreateReplace
     remediation:
       retries: 3
   interval: 30m
   maxHistory: 2

@spicerabot
Copy link
Contributor Author

spicerabot bot commented Oct 31, 2024

--- HelmRelease: kube-system/nvidia-device-plugin ClusterRole: kube-system/nvidia-device-plugin-role

+++ HelmRelease: kube-system/nvidia-device-plugin ClusterRole: kube-system/nvidia-device-plugin-role

@@ -1,12 +1,11 @@

 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   name: nvidia-device-plugin-role
-  namespace: kube-system
   labels:
     app.kubernetes.io/name: nvidia-device-plugin
     app.kubernetes.io/instance: nvidia-device-plugin
     app.kubernetes.io/managed-by: Helm
 rules:
 - apiGroups:
--- HelmRelease: kube-system/nvidia-device-plugin ClusterRoleBinding: kube-system/nvidia-device-plugin-role-binding

+++ HelmRelease: kube-system/nvidia-device-plugin ClusterRoleBinding: kube-system/nvidia-device-plugin-role-binding

@@ -1,12 +1,11 @@

 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   name: nvidia-device-plugin-role-binding
-  namespace: kube-system
   labels:
     app.kubernetes.io/name: nvidia-device-plugin
     app.kubernetes.io/instance: nvidia-device-plugin
     app.kubernetes.io/managed-by: Helm
 subjects:
 - kind: ServiceAccount
--- HelmRelease: kube-system/nvidia-device-plugin DaemonSet: kube-system/nvidia-device-plugin-gpu-feature-discovery

+++ HelmRelease: kube-system/nvidia-device-plugin DaemonSet: kube-system/nvidia-device-plugin-gpu-feature-discovery

@@ -25,12 +25,40 @@

       runtimeClassName: nvidia
       securityContext: {}
       serviceAccountName: nvidia-device-plugin-service-account
       shareProcessNamespace: true
       initContainers:
       - image: nvcr.io/nvidia/k8s-device-plugin:v0.16.2
+        name: gpu-feature-discovery-imex-init
+        command:
+        - /bin/bash
+        - -c
+        args:
+        - |
+          IMEX_NODES_CONFIG_FILE=/etc/nvidia-imex/nodes_config.cfg
+          if [[ -f /config/${IMEX_NODES_CONFIG_FILE} ]]; then
+            echo "Removing cached IMEX nodes config"
+            rm -f /config/${IMEX_NODES_CONFIG_FILE}
+          fi
+
+          if [[ ! -f /driver-root/${IMEX_NODES_CONFIG_FILE} ]]; then
+            echo "No IMEX nodes config path detected; Skipping"
+            exit 0
+          fi
+
+          echo "Copying IMEX nodes config"
+          mkdir -p $(dirname /config/${IMEX_NODES_CONFIG_FILE})
+          cp /driver-root/${IMEX_NODES_CONFIG_FILE} /config/${IMEX_NODES_CONFIG_FILE}
+        volumeMounts:
+        - name: config
+          mountPath: /config
+        - name: driver-root
+          mountPath: /driver-root/etc
+          subPath: etc
+          readOnly: true
+      - image: nvcr.io/nvidia/k8s-device-plugin:v0.16.2
         name: gpu-feature-discovery-init
         command:
         - config-manager
         env:
         - name: ONESHOT
           value: 'true'
@@ -133,12 +161,16 @@

       - name: output-dir
         hostPath:
           path: /etc/kubernetes/node-feature-discovery/features.d
       - name: host-sys
         hostPath:
           path: /sys
+      - name: driver-root
+        hostPath:
+          path: /
+          type: Directory
       - name: available-configs
         configMap:
           name: nvidia-device-plugin-configs
       - name: config
         emptyDir: {}
       nodeSelector:

@spicerabot spicerabot bot force-pushed the renovate/nvidia-device-plugin-0.x branch from 133d8df to adb0b64 Compare November 12, 2024 06:11
@spiceratops spiceratops merged commit 9e7b9a0 into main Nov 12, 2024
6 of 8 checks passed
@spiceratops spiceratops deleted the renovate/nvidia-device-plugin-0.x branch November 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant