Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML search: adjust type signatures for custom HTML scoring #12829

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

  • Adjust the type hint for the scoring argument to the IndexBuilder

Detail

  • Currently we have test coverage that provides a scoring value of None -- but the type signature we have on the class doesn't accept that, strictly speaking.
  • Adjust the type signature to accept that single additional value (since we already have test coverage for it).
  • Also: add a str type to the relevant HTML builder config value.

Relates

cc @danieleades

@jayaddison jayaddison force-pushed the pr-12816-adjustment/indexbuilder-scorer-typing branch from b6838ca to 23882e9 Compare September 28, 2024 16:41
@AA-Turner
Copy link
Member

I think '' is fine (& documented as the default)

@AA-Turner AA-Turner closed this Oct 3, 2024
@jayaddison jayaddison deleted the pr-12816-adjustment/indexbuilder-scorer-typing branch October 3, 2024 19:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants