-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] add build, separate lib and website #57
base: master
Are you sure you want to change the base?
[DRAFT] add build, separate lib and website #57
Conversation
# Conflicts: # package.json # src/website/lib/worklet_processor.min.js # src/website/minified/demo_main.min.js # src/website/minified/local_main.min.js
# Conflicts: # src/spessasynth_lib/synthetizer/worklet_processor.min.js # src/website/minified/demo_main.min.js # src/website/minified/local_main.min.js # src/website/minified/style.min.css
Idea:
Separate repo vs monorepo:
Why:
|
Hi, First of all, thanks for the compliments : ) About splitting up the packages: About spessasynth_lib repo: #!/bin/bash
cd "$(dirname "$0")"
# copy over the lib
rm -rf package
mkdir package
cp -r ../SpessaSynth/src/spessasynth_lib/* package
cp index.js package
cp package.json package
cd package/synthetizer/worklet_system
chmod +x minify_processor.sh
./minify_processor.sh
cd ../../../
ls
chmod +x copy_version.sh
./copy_version.sh
echo "Adding types.d"
# create types
npx --verbose -p typescript tsc package/*.js --declaration --allowJs --target ES6 --emitDeclarationOnly --outDir package/@types
cd "$(dirname "$0")"
cd package
ls
echo "publishing"
npm publish I just run it after I commit and the npm package gets updated. Same thing with releases. |
So, about |
Hi,
Thanks for this great project.
I'm trying to build a piano learning app for my kid, and this project works great for that purpose.
I plan to add some functionality, but before that I think that basic structure should be changed to allow easier collaboration:
Currently the only thing not clear for me is if
in https://github.com/spessasus/SpessaSynth/blob/master/src/website/js/manager/manager.js#L125
is really needed. Since this require the whole library to be served. And if sourcemaps are added is this still needed?