Bolt8 transport #198
Bolt8 transport #198
Conversation
| @@ -43,6 +43,9 @@ def __init__(self, coin=None): | |||
|
|
|||
| # Core items | |||
|
|
|||
| self.is_public = self.boolean('PUBLIC', False) | |||
There was a problem hiding this comment.
IMO True would be a better default. I expect most people will want True, and then it is one fewer thing to configure.
| @@ -43,6 +43,9 @@ def __init__(self, coin=None): | |||
|
|
|||
| # Core items | |||
|
|
|||
| self.is_public = self.boolean('PUBLIC', False) | |||
| self.is_watchtower = self.boolean('WATCHTOWER', False) | |||
| assert not (self.is_public and self.is_watchtower) | |||
There was a problem hiding this comment.
| assert not (self.is_public and self.is_watchtower) | |
| if self.is_public and self.is_watchtower: | |
| raise cls.Error("WATCHTOWERs are not safe to use atm for PUBLIC servers") |
note: operators of public servers might want to use the watchtower functionality for themselves though. So we could allow PUBLIC and WATCHTOWER, but restrict the watchtower-related RPCs to the whitelist.
| @@ -99,6 +101,8 @@ def __init__(self, coin=None): | |||
| if {service.protocol for service in self.services}.intersection(self.SSL_PROTOCOLS): | |||
| self.ssl_certfile = self.required('SSL_CERTFILE') | |||
| self.ssl_keyfile = self.required('SSL_KEYFILE') | |||
| if any([service.protocol == 'bolt8' for service in self.services]): | |||
| self.bolt8_keyfile = self.required('BOLT8_KEYFILE') | |||
There was a problem hiding this comment.
Maybe make this config key optional (and put it inside DB_DIRECTORY) by default.
Regardless, the envvar should be documented.
| from electrum import ecc | ||
| from electrum import logging | ||
| from electrum.lntransport import create_bolt8_server |
There was a problem hiding this comment.
I think it would be good to avoid depending on electrum. Or at least, let's try not to make it a required dependency.
The watchtower functionality could be optional, and if enabled, we could then require electrum.
Re the bolt8 transport bits, we should consider splitting that functionality out of electrum into a separate package, and only depend on that here.
Regardless, electrum is currently not distributed on PyPI. Whatever we end up depending on here, we should either distribute that on PyPI, or maybe make it a git submodule.
companion PR of spesmilo/electrum#8049