Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Mordor, CryptoMix & Jaff extensions #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevross33
Copy link
Contributor

Just some additional extensions. On another note what is people's views on clearing out some of the older extensions from earlier versions of families (i.e. Locky has 8 IOCs alone yet only osiris is being used). There is an argument to be made for older variants being identified as part of research but I am wondering about performance.

Just some additional extensions. On another note what is people's views on clearing out some of the older extensions from earlier versions of families (i.e. Locky has 8 IOCs alone yet only osiris is being used). There is an argument to be made for older variants being identified as part of research but I am wondering about performance.
@KillerInstinct
Copy link
Contributor

If performance is your hold-back then just combine the regexes. RE2 will have no issues.

            (".*\.locky$", ["Locky"]),
            (".*\.zepto$", ["Locky"]),
            (".*\.odin$", ["Locky"]),
            (".*\.shit$", ["Locky"]),
            (".*\.thor$", ["Locky"]),
            (".*\.aesir$", ["Locky"]),
            (".*\.zzzzz$", ["Locky"]),
            (".*\.osiris$", ["Locky"]),

to

            (".*\.(?:locky|zepto|odin|shit|thor|aesir|zzzzz|osiris)$", ["Locky"]),

@kevross33
Copy link
Contributor Author

kevross33 commented May 5, 2017 via email

@kevross33 kevross33 changed the title Add in Mordor and CryptoMix extensions Add in Mordor, CryptoMix & Jaff extensions May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants