Eloquent migration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makokal
reviewed
Sep 8, 2020
Comment on lines
+6
to
+10
| float64 cp_yy # variance of prediction acc. to y | ||
| float64 c_xx # variance of state acc. to x | ||
| float64 c_yy # variance of state acc. to y | ||
| float64[] mode_probabilities # array containing mode probabilities |
There was a problem hiding this comment.
These renaming seems to add more complexity to this migration that necessary. I would suggest keeping the renaming/refactor to a separate effort after the ros1/2 issues are finalised
There was a problem hiding this comment.
Colcon, the compilation tool of ROS2, does not permit capitals in a message field, because of this I had to rename them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points