Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add QuestLogic and JournalData stuff #399

Merged
merged 7 commits into from
Dec 21, 2024
Merged

add QuestLogic and JournalData stuff #399

merged 7 commits into from
Dec 21, 2024

Conversation

Mr-Auto
Copy link
Contributor

@Mr-Auto Mr-Auto commented Nov 24, 2024

No description provided.

@Mr-Auto Mr-Auto marked this pull request as ready for review December 1, 2024 20:23
SereneRuby12
SereneRuby12 reviewed Dec 10, 2024
View reviewed changes
src/game_api/game_manager.hpp Outdated Show resolved Hide resolved
src/game_api/script/usertypes/game_manager_lua.cpp Show resolved Hide resolved
src/game_api/script/usertypes/screen_lua.cpp Show resolved Hide resolved
src/game_api/game_manager.hpp Outdated Show resolved Hide resolved
src/game_api/script/usertypes/level_lua.cpp Show resolved Hide resolved
@Mr-Auto Mr-Auto mentioned this pull request Dec 12, 2024
Merged
SereneRuby12
SereneRuby12 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@SereneRuby12 SereneRuby12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :D
Do I merge on approval or is it better to let you merge, so you can publish change notes along with the merge?

@Mr-Auto Mr-Auto merged commit 6c0b359 into main Dec 21, 2024
10 checks passed
@Mr-Auto Mr-Auto deleted the quest-stuff branch December 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SereneRuby12 SereneRuby12 SereneRuby12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr-Auto @SereneRuby12