add QuestLogic and JournalData stuff #399
Open
+355
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanfer
reviewed
Dec 10, 2024
| screencharacterselect_type["daily_challenge"] = sol::readonly(&ScreenCharacterSelect::daily_challenge); | ||
| /// Short for `screen->next_screen_to_load == SCREEN.TEAM_SELECT and not screen->seeded_run and not screen->daily_challenge` | ||
| screencharacterselect_type["arena"] = sol::property([](ScreenCharacterSelect* screen) -> bool | ||
| { return screen->next_screen_to_load == 10 && !screen->seeded_run && !screen->daily_challenge; }); |
There was a problem hiding this comment.
oh we don't have C++ enums for SCREEN too? it's fine to not have it in this PR if not, unless you want to
There was a problem hiding this comment.
I didn't bother since it's just one value
| @@ -1246,7 +1246,7 @@ void register_usertypes(sol::state& lua) | |||
| auto customtheme_type = lua.new_usertype<CustomTheme>("CustomTheme", sol::constructors<CustomTheme(), CustomTheme(uint8_t, uint8_t), CustomTheme(uint8_t, uint8_t, bool)>(), sol::base_classes, sol::bases<ThemeInfo>()); | |||
| customtheme_type["level_file"] = &CustomTheme::level_file; | |||
| customtheme_type["theme"] = &CustomTheme::theme; | |||
| // NoDoc | |||
| /// NoDoc | |||
There was a problem hiding this comment.
is the NoDoc supposed to work here due to the autodoc changes? or doesn't matter now?
There was a problem hiding this comment.
It was working before since regex was just checking if there is NoDoc before the declaration
Now i changed it to get any comment that starts with /// and then check if the comment is NoDoc or an actual comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.