fix MSVC 19.40 build crashing, fix clangd warnings

[estebanfer]

Fixed latest MSVC build crashing when it injects to spelunky (the MSVC version now used for playlunky autobuild)
Fixed warning -Wdeprecated-this-capture

[estebanfer]

Updating clang to the version used gives me errors completely unrelated to the one in CI :/

[Mr-Auto]

Updating clang to the version used gives me errors completely unrelated to the one in CI :/

Typical at this point

[estebanfer]

Seems like clang made an oopsie in clang 18 and we'll have to wait til the new release that fixes it is out for the CI ThePhD/sol2#1581
Or we could apply the workaround mentioned there in some fork too

[estebanfer]

how do I retry the CI? the new clang version is out

[Mr-Auto]

how do I retry the CI? the new clang version is out

Only mentainors can, but if you want to just try, why not make PR inside your fork?

[estebanfer]

oops now I broke the CI

[estebanfer]

should I also downgrade MSVC 14.39 like in Playlunky or is this fine

[Dregu]

Woah, green!

should I also downgrade MSVC 14.39 like in Playlunky or is this fine

I guess it doesn't matter as long as this code builds and works on both versions?

[estebanfer]

Playlunky didn't seem to work on 14.40 by applying this same fix of _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR, while OL did work. Maybe could be somehow fixed in PL but I couldn't figure out how, I still got the mutex crashes

[estebanfer]

Ideally the clang downgrade step would be removed once it gets updated with the bugfixes, if it compiles after that

[Dregu]

I guess I should merge this then and we'll see what it takes to get spelunky-fyi/Playlunky#53 building next.