-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More screen and GameProps stuff #355
Conversation
Btw ScreenCharacterSelect::unknown69 definitely isn't a TextureRenderingInfo, there's a bunch of run-type flags there and the next screen to load at 0x848. Some of these are written by 22c02260 |
There is a lot wrong with the sceens, specially the unknowns, for now i want to lay down the structs as best as possible, fix anything that was shifted etc. then i can take a closer look at screens of interest |
@@ -44,8 +44,6 @@ void register_usertypes(sol::state& lua) | |||
lua["Screen"]["as_screen_title"] = &Screen::as<ScreenTitle>; | |||
lua["Screen"]["as_screen_menu"] = &Screen::as<ScreenMenu>; | |||
lua["Screen"]["as_screen_options"] = &Screen::as<ScreenOptions>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those even documented somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, but I've also never had to cast screens anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the idea was to use it in like set_post_render_screen
or something
@@ -109,31 +109,6 @@ void Screen::unhook(std::uint32_t id) | |||
} | |||
} | |||
|
|||
void ScreenOnlineLobby::set_code(const std::string& code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i should bring back this function?
or just expose the screen code?
custom_vector<custom_vector<MenuOption>> menu_tree; | ||
custom_vector<uint32_t> menu_index_order; // to go back to, probably needs a better name | ||
|
||
// yes, this is just ScreenControls but up/down are reversed and not left/right for some reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe i should put ScreenControls
with a comment explaining the behavior?
…move a lot of exposed variables for now
No description provided.