Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More screen and GameProps stuff #355

Merged
merged 21 commits into from
Nov 15, 2023
Merged

Conversation

Mr-Auto
Copy link
Contributor

@Mr-Auto Mr-Auto commented Nov 5, 2023

No description provided.

@Dregu
Copy link
Collaborator

Dregu commented Nov 7, 2023

Btw ScreenCharacterSelect::unknown69 definitely isn't a TextureRenderingInfo, there's a bunch of run-type flags there and the next screen to load at 0x848. Some of these are written by 22c02260 init_seeded_run(state, seed) and 22c0d340 init_adventure()

@Mr-Auto
Copy link
Contributor Author

Mr-Auto commented Nov 7, 2023

Btw ScreenCharacterSelect::unknown69 definitely isn't a TextureRenderingInfo, there's a bunch of run-type flags there and the next screen to load at 0x848. Some of these are written by 22c02260 init_seeded_run(state, seed) and 22c0d340 init_adventure()

There is a lot wrong with the sceens, specially the unknowns, for now i want to lay down the structs as best as possible, fix anything that was shifted etc. then i can take a closer look at screens of interest

@@ -44,8 +44,6 @@ void register_usertypes(sol::state& lua)
lua["Screen"]["as_screen_title"] = &Screen::as<ScreenTitle>;
lua["Screen"]["as_screen_menu"] = &Screen::as<ScreenMenu>;
lua["Screen"]["as_screen_options"] = &Screen::as<ScreenOptions>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are those even documented somewhere?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but I've also never had to cast screens anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the idea was to use it in like set_post_render_screen or something

docs/src/includes/_types.md Outdated Show resolved Hide resolved
@@ -109,31 +109,6 @@ void Screen::unhook(std::uint32_t id)
}
}

void ScreenOnlineLobby::set_code(const std::string& code)
Copy link
Contributor Author

@Mr-Auto Mr-Auto Nov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i should bring back this function?
or just expose the screen code?

src/game_api/screen.hpp Outdated Show resolved Hide resolved
src/game_api/screen.hpp Outdated Show resolved Hide resolved
custom_vector<custom_vector<MenuOption>> menu_tree;
custom_vector<uint32_t> menu_index_order; // to go back to, probably needs a better name

// yes, this is just ScreenControls but up/down are reversed and not left/right for some reason
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe i should put ScreenControls with a comment explaining the behavior?

@Mr-Auto Mr-Auto marked this pull request as ready for review November 14, 2023 22:05
@Dregu Dregu merged commit 838e2dd into spelunky-fyi:main Nov 15, 2023
10 checks passed
@Mr-Auto Mr-Auto deleted the more-screen-stuff branch November 26, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants