Add destroy_grid_entity function

[estebanfer]

Adds the destroy_grid_entity function to be able to remove a grid entity from the grid at the same time it gets destroyed, so the neighbor entities can be fixed right after destroying it, and a way to correctly destroy grid entities before the game has created their decorations, to have the correct decorations
I was thinking I could add some optional parameter to disable destroying the items of the grid entity, so if the user wants to do something different with the items, it could be done by the user itself (?)

[Dregu]

I'd also suggest a destroy_grid(x, y, l) so you don't have to figure out what's there when playing with coordinates.

[estebanfer]

I'd also suggest a destroy_grid(x, y, l) so you don't have to figure out what's there when playing with coordinates.

So, a different function with that name right? Or an overload?

[Dregu]

I'd also suggest a destroy_grid(x, y, l) so you don't have to figure out what's there when playing with coordinates.

So, a different function with that name right? Or an overload?

Well the one you already made clearly expects an entity(uid), but I wouldn't mind if this new function has an overload that treats a single argument as uid and 3 as coordinates...

[estebanfer]

It feels a bit weird for me since most overloads have almost the same kind of parameters or just extra ones, though create_illumination already does take either coordinates or uid.
What do you think would be better?

[Dregu]

What do you think would be better?

Well I think of it this way: What is the harm if we add the overload? Will someone accidentally forget the rest of the arguments and something terrible happens when the uid was supposed to be an x-coordinate, or is it just a convenient shorthand with no risk of confusing anyone...

[estebanfer]

well, doesn't make sense passing uid, y position and layer, or passing just x position, hopefully people won't be that dumb 🐈

[estebanfer]

oh and this reminds me that overloads generated in spel2.lua are kinda broken... I'll have to fix that

[Dregu]

oh and this reminds me that overloads generated in spel2.lua are kinda broken... I'll have to fix that

Ah yes the new safe io and os stuff is also missing, I was supposed to make something for it, but it's probably easiest to just manually add io.open_data = io.open or something.

[Dregu]

Still suggesting the overloaded function to be called destroy_grid, as destroy_grid_entity clearly expects an entity...

[estebanfer]

ohh... true