Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arrow-poison tilecodes #1032

Merged
merged 4 commits into from
Oct 9, 2023
Merged

add arrow-poison tilecodes #1032

merged 4 commits into from
Oct 9, 2023

Conversation

estebanfer
Copy link
Contributor

Adds tilecodes from spelunky-fyi/overlunky#330 to the editor

@mauvealerts
Copy link
Contributor

I think you can do the arrows by:

  • add mappings in items.py (see metal_arrow)
  • add to the set in tile_codes.py

For venom, it's a little fuzzier since your sprite is rotated. If that's not important, you could add them similar to the arrows (see poison_bubble1). If you really want to re-orient it, I think the tilecode_extras.py and a custom sprite makes sense.

Sorry this took a while to review. I'm not very familiar with the level editor.

@estebanfer
Copy link
Contributor Author

thanks for the advice, and no problem, it also took me a while to read this 😅

mauvealerts
mauvealerts reviewed Oct 7, 2023
View reviewed changes
Copy link
Contributor

@mauvealerts mauvealerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're having trouble testing, you might want to rebase. I fixed a bug in 20a3403

src/modlunky2/sprites/tilecode_extras.py Outdated
@@ -127,9 +127,18 @@ class StickyTrapSheet(BaseSpriteLoader):
}


class PoisonSheet(BaseSpriteLoader):
_sprite_sheet_path = Path("static/images/arrows_poison.png")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to match the filename (venom.png)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/modlunky2/sprites/items.py
"wood_arrow_poisoned": (5, 4, 6, 5),
"metal_arrow_poisoned": (6, 4, 7, 5),
"arrow_wooden_poison": (5, 4, 6, 5),
"arrow_metal_poison": (6, 4, 7, 5),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these (and venom) need to be added to VALID_TILE_CODES in src\modlunky2\levels\tile_codes.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mauvealerts mauvealerts merged commit 464d330 into spelunky-fyi:main Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauvealerts mauvealerts mauvealerts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estebanfer @mauvealerts