Rework #1
Merged
Rework #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd allow clicking it like with the DataPointer (plus small thing in json)
…es the game stuff, make Spelunky2 class into Singleton design
This reverts commit 69c7c14.
…ryMappedData" as it was only holding pointer to the configuration and some configuration type functions, don't require valid configuration to load toolbar. Removed parameter from `TreeViewMemoryFields` constructor as it's only used for vtable stuff, need to fix later
…pattern lookups there, some optimisations
…tead of array. A lot of optimisations, changes, fixes to the previous commits
… clicking on hex value only do something for pointers
…ield instead of update, allow std::string as data to avoid conversions to QSrting and back. Add class for quick check for enabled columns (in future: don't updated invisible fields, allow show/hide columns by the user), don't move `MemoryField` struct as QVariant data since there is no need
… throw error if json struct have two fields named the same
…ory lookups to single file
…st all the file related stuff to Configuration, move MemoryFieldData to .cpp
…tc. are saved when adding a row to it, so then it basically updates itself, try to reduce the amount of code
…emove all the maps with offsets, try to improve stuff as i go
…more LevelGen files, remove unused StdSet MemoryFieldType
…clean up around the strings view etc.
…tion in the comparison
…freshing when moving thru identical room templates, more vector protection
…re marked as changed and then main struct go null pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointertag to mark struct as pointer instead of making two struct one for inline one for pointer typeDoubletypeSpelunky2.jsonFixes: