Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and many small fixes #34

Merged
merged 36 commits into from
Mar 10, 2023

Conversation

DeionSi
Copy link
Contributor

@DeionSi DeionSi commented Jan 15, 2023

This pull request does multiple things. It was not feasible for me to develop them separately from each other as they are intertwined in many cases.

  • Update all packages to latest version. Remove json5 dependency. Replace serialport with the sub-dependancy of @serialport/bindings-cpp. Remove deprecated request package and replace with native fetch. A lot of small changes as a result electron upgrade.
  • Use NPM jQuery instead of included.
  • Improve styling of selects
  • Imrpove top bar handling (including hiding firmware details which couldn't be clicked on)
  • Re-enable scrolling between the different pages. Changed all button handling to trigger this scrolling.
  • General improved layouts of the different pages.
  • Made base tune warning message into a separate page instead of a separate window.
  • Fix opening ini folder on Windows

Details are in the commits. All functions are working for me with a mega ECU.

Closes #33, #32. #31, #29, #28, #25, #24, #20, #16

@noisymime
Copy link
Collaborator

Looks good and tests out fine! Great work with those dependencies as some of them are a huge mess.

There's a couple of very small layout things I'm not convinced about (The warnings screen change for example) but nothing major and all just stylistic choices.

@noisymime noisymime merged commit 98e7d72 into speeduino:master Mar 10, 2023
@DeionSi DeionSi deleted the update-packages branch March 10, 2023 05:42
@DeionSi
Copy link
Contributor Author

DeionSi commented Mar 10, 2023

Thank you. Please close the pull requests this supercedes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants