Skip to content

Commit

Permalink
stress test: Disable IsDone which conflicts with the trace file (#816)
Browse files Browse the repository at this point in the history
Adding a trace file by default in PR #797 has revealed some incompatibilities between the trace file and several configurations (more details in #813). Keep the trace file and remove the IsDone assertion.
  • Loading branch information
Yuval-Ariel authored Jan 29, 2024
1 parent 94e7a4f commit 536f779
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ db_stress has been updated as well to take into account that some memtables do n
RocksDB has a value of 10 by default and we've added the option to randomize the values from 0 to 100 in https://github.com/speedb-io/speedb/commit/434692a63318036a3995a53001337f18bf467903
* Add more checks for using db_stress with --enable_speedb_features=true
* Proactive Flushes: Have the initiator return a correct answer when it was requested to initate a flush (#812).
* stress test: Adding a trace file by default in PR https://github.com/speedb-io/speedb/pull/797 has revealed some incompatibilities between the trace file and several configurations (more details in https://github.com/speedb-io/speedb/issues/813). Keep the trace file and remove the IsDone assertion.

### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
Expand Down
10 changes: 9 additions & 1 deletion db_stress_tool/expected_state.cc
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,15 @@ class ExpectedStateTraceRecordHandler : public TraceRecord::Handler,
state_(state),
buffered_writes_(nullptr) {}

~ExpectedStateTraceRecordHandler() { assert(IsDone()); }
~ExpectedStateTraceRecordHandler() {
fprintf(
stderr,
"WARNING: ~ExpectedStateTraceRecordHandler - num_write_ops_: %" PRIu64
" max_write_ops_: %" PRIu64 "\n",
num_write_ops_, max_write_ops_);
// assert(IsDone())
;
}

// True if we have already reached the limit on write operations to apply.
bool IsDone() { return num_write_ops_ == max_write_ops_; }
Expand Down

0 comments on commit 536f779

Please sign in to comment.