Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Update #10

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Readme Update #10

merged 2 commits into from
Jan 29, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR fixed the README image verification command that contained an invalid argument. Vault is also used now to circumvent PR release issues due to branch protection rules.

@karl-cardenas-coding karl-cardenas-coding added documentation Improvements or additions to documentation CI/CD CI/CD related changes labels Jan 29, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner January 29, 2024 16:19
@@ -9,7 +9,7 @@ Use the following command to verify the authenticity of the container image. Rep

```shell
cosign verify --key https://raw.githubusercontent.com/spectrocloud/librarium/master/static/cosign.pub \
docker pull ghcr.io/spectrocloud/hello-universe-api:1.0.10
docker ghcr.io/spectrocloud/hello-universe-api:1.0.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker ghcr.io/spectrocloud/hello-universe-api:1.0.10
ghcr.io/spectrocloud/hello-universe-api:1.0.10

Do we have docker in this command?

@karl-cardenas-coding karl-cardenas-coding merged commit 89917a8 into main Jan 29, 2024
5 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the image-fix branch January 29, 2024 16:33
@vault-token-factory-spectrocloud

🎉 This PR is included in version 1.0.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related changes documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants