Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cluster api spectro ignition support #13

Open
wants to merge 9 commits into
base: archive-3oct2023-spectro-master
Choose a base branch
from

Conversation

sadysnaat
Copy link

No description provided.

@spectro-prow
Copy link

Hi @sadysnaat. Thanks for your PR.

I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invidian and others added 9 commits May 12, 2021 10:44
So it can be reused in the future.

Signed-off-by: Mateusz Gozdek <[email protected]>
Based on specified format. Use function to determine format, so more
complex logic can be implemented for selecting the format in the future.

Signed-off-by: Mateusz Gozdek <[email protected]>
So Infrastructure providers can read it from there and act accordingly.

This lift the requirement of each Infrastructure provider to roll their
own bootstapping data format fields, so part of it can be automated.

Signed-off-by: Mateusz Gozdek <[email protected]>
This commit adds Ignition packages next to cloudinit package of CABPK to
open a way to generate bootstrap data in alternative format.

Signed-off-by: Mateusz Gozdek <[email protected]>
cloudinit remains the default format, but if either format is specified
explicilty as 'ignition' or 'spec.ignition' field is set, Ignition will
be used instead.

Signed-off-by: Mateusz Gozdek <[email protected]>
@sadysnaat sadysnaat force-pushed the cluster-api-spectro-ignition-support branch from 705f2a8 to 9723ba7 Compare May 12, 2021 05:16
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadysnaat
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants