Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of cli docker image by removing tar #214

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Reduce size of cli docker image by removing tar #214

merged 3 commits into from
Oct 4, 2023

Conversation

big-andy-coates
Copy link
Member

@big-andy-coates big-andy-coates commented Oct 4, 2023 •
edited
Loading

fixes: #213

  • First change:

Have the Gradle build unpack the distribution tar archive. This means there is no need to install tar or to have the tar file in the Docker image.

Reduces image down to ~600MB

  • Second change:

Change base image to smaller one:

Reduces image down to ~360MB

Reviewer checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant, how
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Ensure any appropriate documentation has been added or amended

@big-andy-coates
Reduce size of cli docker image by removing tar
eb02576 
fixes: #213

Have the Gradle build unpack the distribution tar archive. This means there is no need to install tar or to have the tar file in the Docker image.
@big-andy-coates big-andy-coates added the enhancement New feature or request label Oct 4, 2023
@big-andy-coates big-andy-coates requested a review from a team as a code owner October 4, 2023 13:25
bluemonk3y
bluemonk3y approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@bluemonk3y bluemonk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy squeezy

@big-andy-coates big-andy-coates mentioned this pull request Oct 4, 2023
Merged
@bluemonk3y bluemonk3y merged commit 95f2091 into main Oct 4, 2023
3 checks passed
@bluemonk3y bluemonk3y deleted the remove-tar-from-docker branch October 4, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemonk3y bluemonk3y bluemonk3y approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce size of the docker image
2 participants
@big-andy-coates @bluemonk3y