Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(w3c/headers): validate header links #4037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Feb 16, 2022

Complains if latestVersion doesn't exist, while it also prevents CG drafts from claiming to have a latestVersion.

Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check in detail from computer.

src/w3c/headers.js Show resolved Hide resolved
@sidvishnoi sidvishnoi self-requested a review February 16, 2022 07:23
Comment on lines +37 to +43
${conf.latestVersion !== null
? html`<dt>${l10n.latest_published_version}</dt>
<dd>
${conf.latestVersion
${conf.latestVersion !== ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is it null, and when is it "" in particular?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's null, it shouldn't be included... but when it's ""... I need to check :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants