experiment: try to get line number of errors #3409
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a special comment at the end of each line as a pre-process step (in Node, not respec), we can estimate the location of error in source, which can be very useful in CI. For every element, we can find the "nearest" (with some heuristics) HTML comment matching that pattern and we'll get access to line number.
<style>
,<script>
and<title>
elements. The solution probably involves using a parser like parse5 or htmlparser2, does anyone have some experience with them?showError
can have error location hints, e.g., "at the end of element", "at the start of element", "at line N in this element" (WebIDL.js already gives us last one).screencast_00000.mp4