Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the model diagrams with the model repo #886

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

goneall
Copy link
Member

@goneall goneall commented Feb 18, 2024

This updates the diagrams with the model repo after merging spdx/spdx-3-model#643

@goneall goneall added this to the 3.0-rc2 milestone Feb 18, 2024
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why model-security-profile.png is included when there is a "model Secuirty.png". Included by error? Also file looks like Core+Software not security.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check, this is looking like the core, not security. Also, is this reducnant with model Security.png.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra image.

I noticed this too while on the plane.

The image is present in the model repo - it is stale compared to model Security.png.

BTW - The image was not used in the website or PDF.

@goneall
Copy link
Member Author

goneall commented Feb 27, 2024

Resolved @kestewart feedback, merging

@goneall goneall merged commit bae081c into development/v3.0 Feb 27, 2024
2 checks passed
@goneall goneall deleted the sync-diagrams branch February 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants