Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove SPDX-Lite Annex for RC2 release #879

Closed
wants to merge 1 commit into from

Conversation

goneall
Copy link
Member

@goneall goneall commented Feb 5, 2024

Based on the tech call discussion on Annexes, this will be updated for the next release candidate after RC2 since it depends on a Tag/Value like format
See:
https://docs.google.com/spreadsheets/d/1QHp5QwmBlsmd2iXNy-Y7K6oka_u5qc51iR6Xr0s0Qao/edit#gid=0
Signed-off-by: Gary O'Neall [email protected]

Based on the tech call discussion on Annexes, this will be updated
for the next release candidate after RC2 since it depends on a
Tag/Value like format
See:
https://docs.google.com/spreadsheets/d/1QHp5QwmBlsmd2iXNy-Y7K6oka_u5qc51iR6Xr0s0Qao/edit#gid=0
Signed-off-by: Gary O'Neall <[email protected]>
@goneall goneall added this to the 3.0 milestone Feb 5, 2024
@goneall goneall requested review from zvr and kestewart February 5, 2024 08:36
@goneall goneall mentioned this pull request Feb 5, 2024
32 tasks
@kestewart kestewart changed the title Temporarily remove SPDX-Lite for RC2 release Temporarily remove SPDX-Lite Annex for RC2 release Feb 5, 2024
@kestewart
Copy link
Contributor

Not convinced it depends on TagValue @goneall - but we need to since I can see this being made available in JSON, etc. as well. I updated the title to reflect it's just the ANNEX, not the profile itself that is being removed. I do agree that the annex needs to be rewritten, to pick up the accurate references, and that can happen after rc2.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annex needs to be rewritten, and agree it is not critical path for rc2, so best to drop for now, and re add later.

Rather than drop though, since there are references to it through the text, how about leave the header intact, and put a "will be documented in final release"? That way the linkages won't break. Otherwise we'll have to do a pass through the text and make sure we remove all Annex refs as well.

@goneall
Copy link
Member Author

goneall commented Feb 5, 2024

Annex needs to be rewritten, and agree it is not critical path for rc2, so best to drop for now, and re add later.

Rather than drop though, since there are references to it through the text, how about leave the header intact, and put a "will be documented in final release"? That way the linkages won't break. Otherwise we'll have to do a pass through the text and make sure we remove all Annex refs as well.

@kestewart - If there are references, I agree it would be better. I checked and the Lite profile in the model does not reference the annex. Is there any other possible references? If not, we can safely delete then add back later.

@goneall
Copy link
Member Author

goneall commented Feb 16, 2024

This is superseded by PR #883

@goneall goneall closed this Feb 16, 2024
@goneall goneall deleted the lite-annex branch April 15, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants