Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch strategy to README #1149

Merged
merged 10 commits into from
Nov 16, 2024
Merged

Add branch strategy to README #1149

merged 10 commits into from
Nov 16, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Nov 14, 2024

This implements the branching strategy agreed to on the 5 November 2024 tech call.

Signed-off-by: Gary O'Neall <[email protected]>
@goneall goneall requested review from bact and zvr November 14, 2024 18:26
@goneall goneall added this to the 3.0.1 milestone Nov 14, 2024
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have made few minor suggestions inline.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bact bact added the doc improvement Area where the project documentation needs improvement label Nov 14, 2024
bact and others added 6 commits November 14, 2024 19:16
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
@goneall
Copy link
Member Author

goneall commented Nov 14, 2024

@bact - Thanks for the suggestions - all have been accepted

Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
@goneall
Copy link
Member Author

goneall commented Nov 16, 2024

Since the suggestion from @zvr were accepted and we should have this published with the branches renamed, I'm going to go ahead and merge.

If there are further suggestions, we can create a separate PR.

@goneall goneall merged commit d928c03 into develop Nov 16, 2024
2 checks passed
@goneall goneall deleted the goneall-patch-1 branch November 16, 2024 01:59
@bact
Copy link
Collaborator

bact commented Nov 18, 2024

The actual branch names that we have now are "develop" and "master", not "develop" and "main" as documented.

Screenshot 2024-11-18 at 09 01 25

@goneall
Copy link
Member Author

goneall commented Nov 18, 2024

@bact - Thanks for catching this - the master branch has now been renamed to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc improvement Area where the project documentation needs improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants