-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change branch name for website publication CI to "main" and "develop" #1146
base: develop
Are you sure you want to change the base?
Conversation
Change spdx-spec branch for the website publication to "main". Note that "main" is not exist yet. We have "master" and the content of "master" is not current (3.0.1). Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Also note that with current branch structure, the workflow will not trigger the check in this PR, as the "on: push: branches:" in GitHub Actions is, with changes in this PR, set to "main" and we are not on the "main" yet. We are still on "development/v3.0.1", so there will be no check yet. Has to rerun the check once the branch renaming is done. At that time, it should trigger. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the branch proposal, we won't rename the develop/v3.0.1 to main until we tag it for release.
I'll create a PR to document the branch strategy more fully and get some reviews before proceeding.
@bact 2 questions for you:
|
@goneall Does it sound a plan? |
(Converted to draft to prevent merging for now. See #1151) |
Thanks @bact - sounds like a plan. I just renamed all the branches - so we can go ahead with the other PR's. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
There will be this workflow in "main" branch and in "develop" branch. For example, The workflow should be configured to have an URL without a version number specified be redirected to an URL published from "main" branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall @licquia I'm reviewing this again along with the new branch strategy, and I think we may need to document the mapping between the source branch/tag and the target URL more properly, to cover all known cases, including the publication of translations in supported version (that is not the latest version). Would you mind reviewing #1155 and then we can update this PR please? Thank you. |
Use "main" for branch name for the website publication at https://spdx.github.io/spdx-spec/.
According to Tech Team Meeting 2024-11-05:
Done by updating
REF_SPEC
variable in.github/workflows/publish_v3.yml
(Line 25).Notes
"main" branch is not exist yet.This PR will not be merged until the branches got renamed.VERSION
is the version to be published when running this workflow.VERSION_DEFAULT
is the default version for redirection if no version is specified in the URL.Publishing "support" branch
https://spdx.github.io/spdx-spec/vx.y.z/
):REF_SPEC
,REF_MODEL
,VERSION
andVERSION_ALIASES
variables inpublish_v3.yml
of that branch.VERSION_ALIASES
in the "support" branch should not contain "latest"; it is only reserved for "main" branchVERSION_DEFAULT
should be kept the same across all branches.spec-parser version
spec-parser
directly from its "main" branch (seeREF_SPEC
), with an assumption that the "main" spec-parser will work with any version ofspdx-3-model
and with a directory structure in this workflow (inspdx-spec
).spec-parser
, to be use with a particular branch ofspdx-3-model
and ofspdx-spec
, if needed (in case that there are incompatible changes), we may need to have a release branch/tag inspec-parser
as well.