Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize container views #1505

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Generalize container views #1505

merged 10 commits into from
Feb 20, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Jan 14, 2024

This PR refactors the notion of views to a View interface, and provides views to arrays, structures, and container arrays. It also adds a syntactic-sugar/helper API to define a view of an existing data descriptor. Depends on merging #1504

@tbennun tbennun changed the base branch from master to container-array January 14, 2024 17:51
@tbennun tbennun changed the base branch from container-array to master January 15, 2024 16:04
@tbennun tbennun changed the title Generalized container views Generalize container views Jan 15, 2024
@tbennun tbennun requested a review from alexnick83 January 15, 2024 19:18
@tbennun tbennun changed the base branch from master to container-array January 15, 2024 19:18
Copy link
Contributor

@alexnick83 alexnick83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@tbennun tbennun added the in the merge queue waiting for CI to work again label Jan 16, 2024
JanKleine added a commit to JanKleine/dace that referenced this pull request Feb 14, 2024
@alexnick83 alexnick83 merged commit bd1ddfc into container-array Feb 20, 2024
@alexnick83 alexnick83 deleted the container-view branch February 20, 2024 16:43
@tbennun tbennun removed the in the merge queue waiting for CI to work again label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants