Skip to content

Commit

Permalink
polish: fix switched comments in GraphQLScalarTypeConfig (graphql#4306)
Browse files Browse the repository at this point in the history
I was just trying to understand the new flows for how scalar values are
represented/parsed/serialized, and noticed that the comments for a
couple of these methods looked backwards.

Really hoping I am not just confused about the terminology, and that
these aren't actually correct 😅
  • Loading branch information
hayes authored Dec 3, 2024
1 parent 79ad146 commit 3ad80e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/type/definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -785,9 +785,9 @@ export interface GraphQLScalarTypeConfig<TInternal, TExternal> {
/** Parses an externally provided literal value to use as an input. */
/** @deprecated use `replaceVariables()` and `coerceInputLiteral()` instead, `parseLiteral()` will be removed in v18 */
parseLiteral?: GraphQLScalarLiteralParser<TInternal> | undefined;
/** Coerces an externally provided value to use as an input. */
coerceOutputValue?: GraphQLScalarOutputValueCoercer<TExternal> | undefined;
/** Coerces an internal value to include in a response. */
coerceOutputValue?: GraphQLScalarOutputValueCoercer<TExternal> | undefined;
/** Coerces an externally provided value to use as an input. */
coerceInputValue?: GraphQLScalarInputValueCoercer<TInternal> | undefined;
/** Coerces an externally provided const literal value to use as an input. */
coerceInputLiteral?: GraphQLScalarInputLiteralCoercer<TInternal> | undefined;
Expand Down

0 comments on commit 3ad80e4

Please sign in to comment.