Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Middlewares" namespace to "Middleware" #2499

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

drbyte
Copy link
Collaborator

@drbyte drbyte commented Sep 13, 2023

Ref #2496

@drbyte drbyte force-pushed the rename-middlewares-to-singular branch from c604def to 7b05453 Compare September 13, 2023 19:10
@drbyte drbyte merged commit f9069aa into main Sep 18, 2023
37 checks passed
@drbyte drbyte deleted the rename-middlewares-to-singular branch September 18, 2023 20:01
@drbyte
Copy link
Collaborator Author

drbyte commented Sep 19, 2023

@tabacitu will this create any huge complications with Backpack?

@tabacitu
Copy link
Contributor

Nope, PermissionManager doesn't use the middleware directly, so it won't affect it at all. Thanks for asking, though!

@KevinEscobarV
Copy link

This change caused the middlewares to fail when updating the package.

Target class [Spatie\Permission\Middleware\RoleMiddleware] does not exist.

Middleware is still written in the documentation.

image

@drbyte
Copy link
Collaborator Author

drbyte commented Oct 21, 2023

@KevinEscobarV Apologies: the online docs site is out of sync with the release. They're incorrectly showing v6 docs even though you've selected v5.
It should be sorted out as soon as v6 is released, which will be within a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants